Update contrib.sessions.backends
#2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Aug 25, 2024
| @overload | ||
| async def aget(self, key: str, default: Any) -> Any: ... | ||
| @overload | ||
| async def aget(self, key: str, default: _T) -> Any | _T: ... # type: ignore[misc] |
There was a problem hiding this comment.
I would suggest to remove this case, Any | _T is still Any
There was a problem hiding this comment.
I copied the signatures over from typeshed, but indeed because _VT is Any we can simplify this.
There was a problem hiding this comment.
However, pyright may retain the type information:
For a better user experience, maybe this can be useful?
There was a problem hiding this comment.
I would still prefer not to complicate the signature, cause it does not provide anything extra, but is still visible in the autosuggestions / docs / etc.
sobolevn
reviewed
Aug 26, 2024
Viicos
force-pushed
the
contrib-sessions-backends
branch
from
ff4183c to
4e7967d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Related issues