Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1: Deprecate CheckConstraint.check #2331

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Aug 9, 2024

@q0w q0w force-pushed the me-check-constraint branch from d28a5ac to d601f6e Compare August 9, 2024 08:20
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use typing_extensions.deprecated on the appropriate overload instead

@q0w q0w requested a review from sobolevn August 10, 2024 14:00
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit ead941f into typeddjango:master Aug 22, 2024
36 checks passed
@q0w q0w deleted the me-check-constraint branch August 22, 2024 13:01
asottile-sentry pushed a commit to getsentry/sentry-forked-django-stubs that referenced this pull request Sep 11, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
asottile-sentry added a commit to getsentry/sentry-forked-django-stubs that referenced this pull request Sep 11, 2024
* add cache_name for django 5.1 (typeddjango#2365)

* 5.1: Deprecate CheckConstraint.check (typeddjango#2331)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Co-authored-by: Anthony Sottile <[email protected]>
Co-authored-by: q0w <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants