Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't populate a type arg for non generic managers #2314

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

flaeppe
Copy link
Member

@flaeppe flaeppe commented Aug 3, 2024

We probably want a more sophisticated implementation of this to get things right when a type has multiple arguments, specifically bounded, etc. But as a first step, this can at least eliminate the obviously invalid ones.

Related issues

mypy_django_plugin/transformers/models.py Outdated Show resolved Hide resolved
mypy_django_plugin/transformers/models.py Outdated Show resolved Hide resolved
@flaeppe flaeppe requested a review from sobolevn August 3, 2024 10:34
@flaeppe flaeppe merged commit ef501f2 into typeddjango:master Aug 3, 2024
36 checks passed
@flaeppe flaeppe deleted the fix/invalid-manager-type-args branch August 3, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants