Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Any for ConnectionProxy attributes #2311

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Use Any for ConnectionProxy attributes #2311

merged 1 commit into from
Aug 2, 2024

Conversation

RealOrangeOne
Copy link
Contributor

Whilst the type is generic, it is not a wrapper - __getattr__ should not return the inner type.

Whilst the type is generic, it is not a wrapper - `__getattr__` should not return the inner type.
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit 2b6fdac into typeddjango:master Aug 2, 2024
36 checks passed
@RealOrangeOne RealOrangeOne deleted the chore/fix-connection-proxy-types branch August 2, 2024 13:06
RealOrangeOne added a commit to RealOrangeOne/django-tasks that referenced this pull request Aug 2, 2024
`mypy` issues were caused by typeddjango/django-stubs#2311, but this improves the types further.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants