Check correct model on other side of many to many reverse filtering #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the manager type there could be different model arguments. For a `ManyRelatedManager` the argument is the `through` model, but we want to check the `to` model. As a simple starter we stash the `to` model in the manager's metadata and set a precedence on fetching the `to` model from metadata.
flaeppe
commented
Jul 28, 2024
Comment on lines
+1483
to
+1485
| other.mymodel_set.filter(xyz__isnull=True) # E: Cannot resolve keyword 'xyz' into field. Choices are: id, others [misc] | ||
| other.mymodel_set.get(xyz__isnull=True) # E: Cannot resolve keyword 'xyz' into field. Choices are: id, others [misc] | ||
| other.mymodel_set.exclude(xyz__isnull=True) # E: Cannot resolve keyword 'xyz' into field. Choices are: id, others [misc] |
There was a problem hiding this comment.
We actually had incorrect tests for the issue fixed here .. 🙂
|
@sobolevn it might be a bunch of false negatives due to the issue here that will come from |
Co-authored-by: sobolevn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the manager type there could be different model arguments. For a
ManyRelatedManagerthe argument is thethroughmodel, but we want to check thetomodel.As a simple starter we stash the
tomodel in the manager's metadata and set a precedence on fetching thetomodel from metadata.Related issues
ManyToManyField#2275