Check model fields on filtering methods of queryset types #2277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we should check some methods on both
Manager
andQuerySet
since theManager
class is a bit special as it is a type "merged" fromBaseManager
andQuerySet
.@sobolevn I think this could be a nice addition before releasing
5.0.3
, or what do you think?Thinking that the use cases from the test included here aren't too foreign: