Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Unify plugin check for model type info #2263

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Refactor: Unify plugin check for model type info #2263

merged 1 commit into from
Jul 17, 2024

Conversation

flaeppe
Copy link
Member

@flaeppe flaeppe commented Jul 16, 2024 •
edited
Loading

Replace is_model_subclass_info with is_model_type helper. Some continued work of #1853

Related issues

@flaeppe
Unify plugin check for model type info
5040599 
Replace `is_model_subclass_info` with `is_model_type` helper
@flaeppe flaeppe added the mypy-plugin Issues specific to mypy_django_plugin label Jul 16, 2024
@sobolevn sobolevn merged commit ac36393 into typeddjango:master Jul 17, 2024
36 checks passed
@flaeppe flaeppe deleted the fix/unify-is-model-chk branch July 28, 2024 17:40
@flaeppe flaeppe mentioned this pull request Jul 28, 2024
Merged
@Niicck Niicck mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
mypy-plugin Issues specific to mypy_django_plugin
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

var-annotated error with imported BaseModel, related to namespace module
2 participants
@flaeppe @sobolevn