Update admin.sites._ViewType bound to allow StreamingHttpResponse

[savanto]

Issue

From the Django documentation:

The StreamingHttpResponse is not a subclass of HttpResponse ...

Because of this, creating an admin view that returned a StreamingHttpResponse was causing the following Mypy error:

testing/admin.py:14: error: Value of type variable "_ViewType" of "admin_view" of "AdminSite" cannot be "Callable[[HttpRequest], StreamingHttpResponse]"  [type-var]

Changes

This updates the admin _ViewType type-var bound to allow a Callable that can return a union of HttpResponse | StreamingHttpResponse HttpResponseBase.

After this update to the stubs file, the Mypy error is no longer reproducible.

---

I was not able to find any open issues related to this. This change can be tested using the following code snippets:

# testing/models.py
from django.db import models


class Model(models.Model):
    pass

# testing/admin.py
from __future__ import annotations

from django.contrib import admin
from django.http import HttpRequest, StreamingHttpResponse
from django.urls import URLPattern, path

from testing.models import Model


@admin.register(Model)
class Admin(admin.ModelAdmin[Model]):
    def get_urls(self) -> list[URLPattern]:
        return [
            path("_stream/", self.admin_site.admin_view(self.get_stream), name="get_stream"),
            *super().get_urls(),
        ]

    def get_stream(self, _request: HttpRequest) -> StreamingHttpResponse:
        return StreamingHttpResponse(("a", "b", "c"))

Testing

I tested this manually by running Mypy before and after the change.

I was not able to run pytest successfully before or after the change (388 failures with ModuleNotFoundError: No module named 'scripts').

I was not able to run stubtest.sh successfully before or after the change (1928 failures with unused allowlist entry ...).

All pre-commit run --all-files checks passed.

[sobolevn]

Thanks!