Do many related manager creation during semantic analysis #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When finding a `ManyToManyField` we can directly create 2 `ManyRelatedManager`s, one for each side of the relation.
flaeppe
commented
Jun 22, 2024
Comment on lines
+30
to
+36
| # '<Model>_ManyRelatedManager' entries are plugin generated and these subclasses only exist | ||
| # _locally/dynamically_ runtime -- Created via | ||
| # 'django.db.models.fields.related_descriptors.create_forward_many_to_many_manager' | ||
| django.contrib.auth.models.Group_ManyRelatedManager | ||
| django.contrib.auth.models.Permission_ManyRelatedManager | ||
| django.contrib.auth.models.User_ManyRelatedManager | ||
|
|
There was a problem hiding this comment.
These are only here since the stubs includes = ManyToManyField(...) in the following places:
django-stubs/django-stubs/contrib/auth/models.pyi
Lines 34 to 38 in ec37d06
django-stubs/django-stubs/contrib/auth/models.pyi
Lines 59 to 62 in ec37d06
Once they would move to a type hint form like: field: ManyToManyField[..., ...] they will disappear from the allowlist.
sobolevn
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When finding a
ManyToManyFieldwe can directly create 2ManyRelatedManagers, one for each side of the relation. This makes the model declaring theManyToManyFieldbe the one who contributes theManyRelatedManagers.Trying to place some related code closer to each other. This time we move some code out of the type checking phase to semantic analysis.
Refs:
ManyToManyDescriptorand fixModel.<manytomany>.throughtyping #1805ManyRelatedManager.throughattribute and generic type parameter #2026