5.0: Update django.db.models.constraints.UniqueConstraint #2175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
May 21, 2024
There was a problem hiding this comment.
Please, reflect this line as well: https://github.com/django/django/blob/15fff62d5d8f28b6b61d63341535c9aafc64c865/django/db/models/constraints.py#L356
steve148
force-pushed
the
feat/unique-constraint-nulls-distinct
branch
2 times, most recently
from
8a811fb to
5e5817c
Compare
|
@sobolevn I amended the change, let me know if this is what you meant. I added the attribute to the class so it shows up as an arg on both the init and as an instance attribute. I also added a quick test to make sure it works. |
sobolevn
reviewed
May 21, 2024
Reflects the nulls_distinct option of the UniqueConstraint class. Adds the attribute and the arg to the two versions of the __init__ type definitions. https://docs.djangoproject.com/en/5.0/ref/models/constraints/#nulls-distinct
steve148
force-pushed
the
feat/unique-constraint-nulls-distinct
branch
from
5e5817c to
b24240e
Compare
sobolevn
approved these changes
May 21, 2024
|
This is big - thank you @steve148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Adds in nulls_distinct field to the UniqueConstraint class. Field can be None or a boolean.
https://docs.djangoproject.com/en/5.0/ref/models/constraints/#nulls-distinct
Related issues
Refs #1493
Feedback
None from me. Let me know if I missed anything.