Update django to 5.0.5 #2131
Merged
Update django to 5.0.5 #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
reviewed
May 7, 2024
intgr
added
the
release notes reminder
|
The new |
sobolevn
commented
May 7, 2024
| @@ -393,6 +393,10 @@ django.urls.resolvers.URLPattern.lookup_str | |||
| django.urls.resolvers.URLResolver.url_patterns | |||
| django.urls.resolvers.URLResolver.urlconf_module | |||
| django.utils.connection.BaseConnectionHandler.settings | |||
| django.db.models.Q.referenced_base_fields | |||
There was a problem hiding this comment.
We also have to figure out a way to work with cached_property without this hack
There was a problem hiding this comment.
I think Django was planning to replace their homegrown cached_property implementation with functools.cached_property in 5.1 or 5.2.
If we have the patience to wait until then, this will resolve itself 😄
There was a problem hiding this comment.
I think it might take quite some time? According to this comment and ticket https://code.djangoproject.com/ticket/30949#comment:14
Or is it mentioned to be replaced someplace else?
There was a problem hiding this comment.
No, I think you're right, it will take years.
5 tasks
flaeppe
removed
the
release notes reminder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2130