Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare django-stubs-ext for QuerySet typevar refactor #2117

Merged
merged 1 commit into from
May 3, 2024
Merged

Prepare django-stubs-ext for QuerySet typevar refactor #2117

merged 1 commit into from
May 3, 2024

Conversation

intgr
Copy link
Collaborator

@intgr intgr commented May 3, 2024 •
edited
Loading

If we merge this first, and don't change aliases.py later, then we can be sure that next django-stubs-ext 5.0.1 remains compatible with django-stubs 5.0.0 (since CI will have checked both combinations)

@intgr intgr mentioned this pull request May 3, 2024
Merged
2 tasks
@intgr intgr added the django-stubs-ext Issues or changes involving django-stubs-ext package label May 3, 2024
sobolevn
sobolevn approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this! This feature has multiple tests, so if they pass - I am quite confident.

@intgr intgr merged commit 50fdc5a into typeddjango:master May 3, 2024
40 checks passed
@intgr intgr deleted the prepare-django-stubs-ext-queryet branch May 3, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees

@sobolevn sobolevn

Labels
django-stubs-ext Issues or changes involving django-stubs-ext package
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intgr @sobolevn