5.0: Update django.contrib.admin.widgets
#2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
May 2, 2024
| @@ -21,12 +21,24 @@ class FilteredSelectMultiple(forms.SelectMultiple): | |||
| choices: _Choices = ..., | |||
| ) -> None: ... | |||
|
|
|||
| class AdminDateWidget(forms.DateInput): | |||
| class BaseAdminDateWidget(forms.DateInput): | |||
| class Media: | |||
There was a problem hiding this comment.
CC @flaeppe
I think that defining such classes may cause an error when defining subclasses of widgets.
It is close to out Meta case.
There was a problem hiding this comment.
@sobolvn I get an error in stustest if I delete that Media case. What should I do about this??
error: django.contrib.admin.widgets.BaseAdminDateWidget.Media is not present in stub
Stub: in file /Users/sajh/Documents/project/django-stubs/django-stubs/contrib/admin/widgets.pyi
MISSING
Runtime: in file /Users/sajh/.pyenv/versions/3.11.5/lib/python3.11/site-packages/django/contrib/admin/widgets.py:53
def ()
error: django.contrib.admin.widgets.BaseAdminTimeWidget.Media is not present in stub
Stub: in file /Users/sajh/Documents/project/django-stubs/django-stubs/contrib/admin/widgets.pyi
MISSING
Runtime: in file /Users/sajh/.pyenv/versions/3.11.5/lib/python3.11/site-packages/django/contrib/admin/widgets.py:69
def ()
Should I not delete that part?
There was a problem hiding this comment.
Let's ignore it for now, we can later decide what to do.
There was a problem hiding this comment.
I revised what you said :)
sobolevn
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Update stubs for
django.contrib.admin.widgetsfor Django 5.0.django.contrib.admin.widgetsdjango.contrib.admin.widgets.BaseAdminDateWidgetwas addeddjango.contrib.admin.widgets.AdminDateWidgetwas changeddjango.contrib.admin.widgets.BaseAdminTimeWidgetwas addeddjango.contrib.admin.widgets.AdminTimeWidgetwas changeddjango.contrib.admin.widgets.RelatedFieldWidgetWrapper.choiceswas addedRelated issues
Refs
Upstream PR
django.contrib.admin.widgets.RelatedFieldWidgetWrapper.choicesdjango.contrib.admin.widgets.BaseAdminDateWidgetdjango.contrib.admin.widgets.AdminDateWidgetdjango.contrib.admin.widgets.BaseAdminTimeWidgetdjango.contrib.admin.widgets.AdminTimeWidget