Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0: Rename save_existing arg instance to obj #1971

Merged
merged 1 commit into from
Feb 25, 2024
Merged

5.0: Rename save_existing arg instance to obj #1971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion django-stubs/forms/models.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class BaseModelFormSet(Generic[_M, _ModelFormT], BaseFormSet[_ModelFormT]):
def initial_form_count(self) -> int: ...
def get_queryset(self) -> _IndexableCollection[_M]: ...
def save_new(self, form: _ModelFormT, commit: bool = ...) -> _M: ...
def save_existing(self, form: _ModelFormT, instance: _M, commit: bool = ...) -> _M: ...
def save_existing(self, form: _ModelFormT, obj: _M, commit: bool = ...) -> _M: ...
def delete_existing(self, obj: _M, commit: bool = ...) -> None: ...
saved_forms: list[_ModelFormT]
def save_m2m(self) -> None: ...
Expand Down
3 changes: 0 additions & 3 deletions scripts/stubtest/allowlist_todo_django50.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ django.contrib.gis.db.models.Q.identity
django.contrib.gis.db.models.Value.allowed_default
django.contrib.gis.db.models.When.allowed_default
django.contrib.gis.forms.BaseForm._html_output
django.contrib.gis.forms.BaseModelFormSet.save_existing
django.contrib.gis.forms.BoundField.get_context
django.contrib.gis.forms.BoundField.template_name
django.contrib.gis.forms.ClearableFileInput.checked
Expand Down Expand Up @@ -218,7 +217,6 @@ django.db.models.sql.query.Query.join
django.db.models.sql.query.Query.resolve_lookup_value
django.db.models.sql.query.Query.setup_joins
django.forms.BaseForm._html_output
django.forms.BaseModelFormSet.save_existing
django.forms.BoundField.get_context
django.forms.BoundField.template_name
django.forms.ClearableFileInput.checked
Expand All @@ -229,7 +227,6 @@ django.forms.fields.CallableChoiceIterator
django.forms.fields.Field.__init__
django.forms.fields_for_model
django.forms.forms.BaseForm._html_output
django.forms.models.BaseModelFormSet.save_existing
django.forms.models.fields_for_model
django.forms.renderers.BaseRenderer.field_template_name
django.forms.renderers.Jinja2DivFormRenderer.__init__
Expand Down