[5.1] Add slicing notation to F expressions #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
added
the
blocked
Viicos
commented
Jan 5, 2024
intgr
changed the title
sobolevn
reviewed
Aug 21, 2024
| @@ -1,7 +1,7 @@ | |||
| import datetime | |||
| from collections.abc import Callable, Iterable, Iterator, Mapping, Sequence | |||
| from decimal import Decimal | |||
| from typing import Any, ClassVar, Generic, Literal, TypeVar | |||
| from typing import Any, ClassVar, Generic, Literal, NoReturn, TypeVar | |||
There was a problem hiding this comment.
Is there a specific reason to do so? I know they are equivalent but I like sticking to NoReturn for return values. What do you think?
sobolevn
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See django/django#17596
Feel free to merge this whenever is the right time (django 5.1 isn't released yet)