Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModuleType as a possible type to URLResolver.urlconf_name #1891

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Add ModuleType as a possible type to URLResolver.urlconf_name #1891

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b78911
Add `ModuleType` as a possile type to `URLResolver.urlconf_name`
Viicos Dec 25, 2023
082322a
Update resolvers.pyi
Viicos Dec 25, 2023
2b5c42b
Remove `None` as a possible value
Viicos Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion django-stubs/urls/resolvers.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class URLPattern:

class URLResolver:
pattern: _Pattern
urlconf_name: str | None | Sequence[_AnyURL]
urlconf_name: str | None | Sequence[_AnyURL] | ModuleType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the __init__ type as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems to be set in the __init__ here

callback: None
default_kwargs: dict[str, Any]
namespace: str | None
Expand Down