Rename SuccessURLAllowedHostsMixin to RedirectURLMixin and hint missing attributes #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
reviewed
Aug 3, 2023
django-stubs/contrib/auth/views.pyi
Outdated
| def get_redirect_url(self) -> str: ... | ||
| def get_success_url_allowed_hosts(self) -> set[str]: ... | ||
| def get_default_redirect_url(self) -> str: ... | ||
|
|
||
| class SuccessURLAllowedHostsMixin: |
There was a problem hiding this comment.
Some more changes look warranted...
SuccessURLAllowedHostsMixin no longer exists in Django 4.2, LoginView and LogoutView should inherit from RedirectURLMixin instead.
intgr
requested changes
Aug 9, 2023
Per Django 4.1 release notes (https://docs.djangoproject.com/en/4.2/releases/4.1/#miscellaneous): "The undocumented django.contrib.auth.views.SuccessURLAllowedHostsMixin mixin is replaced by RedirectURLMixin."
si14
force-pushed
the
new-stub-redirecturlmixin
branch
from
2b408dc to
d7cd899
Compare
|
@intgr fixed, all tests are green |
intgr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple stub for
contrib.auth.views.RedirectURLMixin.I noticed that it was in the todolist and I needed it, so here it is.