-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set python_version
and fix uppercase builtins
#1577
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,8 +15,8 @@ disallow_untyped_defs = true | |
disallow_incomplete_defs = true | ||
show_error_codes = false | ||
disable_error_code = empty-body | ||
python_version = 3.11 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
So if we override this setting, we lose test coverage with different variations of I very much prefer the modern formatting of types in error messages, but still I would err on the side of caution and prioritize test coverage here. I wish mypy had a way to override There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I agree - we cannot touch |
||
# TODO: update our output assertions to match a new syntax | ||
force_uppercase_builtins = true | ||
force_union_syntax = true | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that
show_error_codes = false
also exists here as legacy, and should be fixed eventually.You can move it below the
# TODO
comment you have added.