Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing __init__.py in django_stubs_ext.db #1460

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Fix missing __init__.py in django_stubs_ext.db #1460

merged 1 commit into from
Apr 27, 2023

Conversation

monosans
Copy link
Contributor

The django_stubs_ext 4.2.0 release does not have a db package because it is missing __init__.py.

@adamchainz
Copy link
Contributor

@monosans what issues are you seeing? After PEP420, folders without __init__.py should still function as packages.

@intgr if this is an issue, let's add https://github.com/adamchainz/flake8-no-pep420 to flake8 configuration.

@intgr
Copy link
Collaborator

intgr commented Apr 27, 2023

This PR references the issue described here: #1450 (comment)

I tested python setup.py sdist from this branch and it still produced an archive without db/models.py. Unless I messed something up.

I think something needs to be changed in django_stubs_ext/setup.py, but I haven't yet looked into it in depth.

@intgr
Copy link
Collaborator

intgr commented Apr 27, 2023

My bad, this PR indeed fixes the issue, thanks!

├── django-stubs-ext-4.2.0
│   ├── PKG-INFO
│   ├── README.md
│   ├── django_stubs_ext
│   │   ├── __init__.py
│   │   ├── aliases.py
│   │   ├── annotations.py
│   │   ├── db
│   │   │   ├── __init__.py
│   │   │   └── models.py

@intgr intgr changed the title hotfix: Add missing __init__.py in django_stubs_ext.db Fix missing __init__.py in django_stubs_ext.db Apr 27, 2023
Copy link
Collaborator

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!

@intgr intgr merged commit ad21bd9 into typeddjango:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants