Fix ListFilter's expected_parameters return type #1373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ListFilter
's expected_parameters' return type is defined aslist[str] | None
, which is incorrect in my opinion as:FieldListFilter
subclass returnsNone
it will raise here asNone
is not iterableSimpleListFilter
returns[None]
, which is not allowed by the current return type.This PR changes the return type to
list[str | None]
.Related issues