Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListFilter's expected_parameters return type #1373

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

pheki
Copy link
Contributor

@pheki pheki commented Feb 22, 2023

Currently ListFilter's expected_parameters' return type is defined as list[str] | None, which is incorrect in my opinion as:

  • If a FieldListFilter subclass returns None it will raise here as None is not iterable
  • The default implementation of SimpleListFilter returns [None], which is not allowed by the current return type.

This PR changes the return type to list[str | None].

Related issues

  • None, but I can open one if required

Copy link
Collaborator

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@intgr intgr merged commit 0fbd90a into typeddjango:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants