Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some errors in GeoDjango stubs #1335

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Fix some errors in GeoDjango stubs #1335

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d7ac13
Fix overloading of GeoDjango Layer.get_geoms
ciscorn Jan 23, 2023
41e0bab
geometry's wkb is memoryview, not bytes
ciscorn Jan 23, 2023
6bdb822
Fix default value for geos param
ciscorn Jan 23, 2023
b324b9e
ewkb is also memoryview
ciscorn Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion django-stubs/contrib/gis/gdal/geometries.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class OGRGeometry(GDALBase):
@property
def wkb_size(self) -> int: ...
@property
def wkb(self) -> bytes: ...
def wkb(self) -> memoryview: ...
@property
def wkt(self) -> str: ...
@property
Expand Down
4 changes: 2 additions & 2 deletions django-stubs/contrib/gis/gdal/layer.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class Layer(GDALBase):
spatial_filter: OGRGeometry | None
def get_fields(self, field_name: str) -> list[Any]: ...
@overload
def get_geoms(self, geos: Literal[True] = ...) -> OGRGeometry: ...
def get_geoms(self, geos: Literal[False] = ...) -> list[OGRGeometry]: ...
@overload
def get_geoms(self, geos: Literal[False]) -> GEOSGeometry: ...
ciscorn marked this conversation as resolved.
Show resolved Hide resolved
def get_geoms(self, geos: Literal[True]) -> list[GEOSGeometry]: ...
def test_capability(self, capability: AnyStr) -> bool: ...
2 changes: 1 addition & 1 deletion django-stubs/contrib/gis/geos/geometry.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class GEOSGeometryBase(GEOSBase):
def json(self) -> str: ...
geojson: str
@property
def wkb(self) -> bytes: ...
def wkb(self) -> memoryview: ...
@property
def ewkb(self) -> bytes: ...
ciscorn marked this conversation as resolved.
Show resolved Hide resolved
@property
Expand Down