Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors bad default values, now using Ellipsis #132

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Refactors bad default values, now using Ellipsis #132

merged 2 commits into from
Aug 13, 2019

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 12, 2019 •
edited
Loading

Turing on flake8 for stubs seems like an impossible task. There are so many violations out there.

And I do not want to rewrite them all with autopep8 or similar tools. I guess that history is more important than some specific style in this case.

So, all in all:

  1. .editorconfig is introduced
  2. all =None are refactored to Optional[ ] = ...

Closes #128

@sobolevn sobolevn requested a review from mkurnikov August 12, 2019 16:35
@sobolevn sobolevn merged commit 7f47605 into master Aug 13, 2019
@mkurnikov
Copy link
Member

Wait, [*] with indent=2 means that all stubs will be indented with 2 spaces?

@sobolevn
Copy link
Member Author

Oops, I will fix it in master. That's the correct style: https://github.com/dry-python/returns/blob/master/.editorconfig

sobolevn added a commit that referenced this pull request Aug 13, 2019
@sobolevn
Fixes .editorconfig, refs #132
737fd23
@mkurnikov
Copy link
Member

And .yaml will be too... I like .yaml with 4 spaces, considering that it has python embedded, and it's always 4 spaces indented.

@mkurnikov
Copy link
Member

Could you remove .editorconfig for now, or at least remove indentation configuration?

sobolevn added a commit that referenced this pull request Aug 13, 2019
@sobolevn
Fixes yaml spacing, refs #132
825931d
sobolevn added a commit that referenced this pull request Aug 13, 2019
@sobolevn
Removes .editorconfig, refs #132
0545c2d
@sobolevn sobolevn deleted the issue-128 branch August 13, 2019 12:06
@hoefling hoefling mentioned this pull request Nov 12, 2022
Closed
voidus pushed a commit to voidus/django-stubs that referenced this pull request Apr 23, 2024
@last-partizan
fix: Fix type for ManyToManyRelatedManager.through (typeddjango#132)
cbf6072 
This isn't "RelatedManager", this is model itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurnikov mkurnikov mkurnikov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup flake8-pyi to lint stubs
2 participants
@sobolevn @mkurnikov