Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Django 4.1 constraints violation_error_message #1263

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Add Django 4.1 constraints violation_error_message #1263

merged 3 commits into from
Nov 16, 2022

Conversation

martinlehoux
Copy link
Contributor

@martinlehoux martinlehoux changed the title Master Add Django 4.1 constraints violation_error_message Nov 16, 2022
sobolevn
sobolevn reviewed Nov 16, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

django-stubs/db/models/constraints.pyi Outdated Show resolved Hide resolved
tests/typecheck/db/models/test_constraints.yml Outdated
@@ -35,3 +35,13 @@
main:4: note: Possible overload variants:
main:4: note: .*
main:4: note: .*

- case: constraint_violation_error_message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need tests for simple things. We only test plugins / complex overloads / etc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

adamchainz and others added 2 commits November 16, 2022 12:06
@adamchainz
remove test
19b48e5
@adamchainz @sobolevn
always present
0f87990 
Co-authored-by: Nikita Sobolev <[email protected]>
adamchainz
adamchainz approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixes

@adamchainz adamchainz merged commit 0ae827d into typeddjango:master Nov 16, 2022
@martinlehoux
Copy link
Contributor Author

Thanks for pushing this haha

@realsuayip realsuayip mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

@adamchainz adamchainz adamchainz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Django 4.1 constraints violation_error_message
3 participants
@martinlehoux @adamchainz @sobolevn