Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Optional to LANGUAGE_COOKIE_SAMESITE #1246

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Add Optional to LANGUAGE_COOKIE_SAMESITE #1246

merged 1 commit into from
Nov 9, 2022

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Nov 9, 2022

Reverse an incorrect edit that was squashed into my change in #1228. The default value of LANGUAGE_COOKIE_SAMESITE is None (documentation, code), so an annotation that excludes None is not type-safe.

@andersk
Add Optional to LANGUAGE_COOKIE_SAMESITE
1fac305 
Reverse an incorrect edit that was squashed into my change in typeddjango#1228.
The default value of LANGUAGE_COOKIE_SAMESITE is None, so an
annotation that excludes None is not type-safe.

Signed-off-by: Anders Kaseorg <[email protected]>
@andersk andersk mentioned this pull request Nov 9, 2022
Merged
@sobolevn sobolevn requested a review from adamchainz November 9, 2022 20:22
adamchainz
adamchainz approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks, I spotted your comment after merge and have been meaning to come back to that. You're right that, for whatever reason, Django has None here, so we should match it.

@adamchainz adamchainz merged commit cb5f201 into typeddjango:master Nov 9, 2022
@andersk andersk deleted the language-cookie-samesite-type branch November 10, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamchainz adamchainz adamchainz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andersk @adamchainz