Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add django.db.models.query.BaseIterable and subclasses #1242

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Add django.db.models.query.BaseIterable and subclasses #1242

merged 3 commits into from
Nov 11, 2022

Conversation

CircuitCipher
Copy link
Contributor

I have made things!

This PR addresses #1237 and adds the following classes to django.db.models.query:

  • BaseIterable
  • ModelIterable
  • RawModelIterable
  • ValuesIterable
  • ValuesListIterable
  • NamedValuesListIterable
  • FlatValuesListIterable

Related issues

adamchainz
adamchainz reviewed Nov 9, 2022
View reviewed changes
Copy link
Contributor

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add QuerySet._iterable_class at the same time? It seems to me that if you need to touch these classes, you probably want that attr defined.

Otherwise, LGTM

@CircuitCipher
Copy link
Contributor Author

CircuitCipher commented Nov 9, 2022 •
edited
Loading

Maybe we could add QuerySet._iterable_class at the same time? It seems to me that if you need to touch these classes, you probably want that attr defined.

I'll see what I can do about it today

@adamchainz adamchainz changed the title Add BaseIterable and subclasses (e.g. ModelIterable) to query.pyi Add django.db.models BaseIterable and subclasses Nov 11, 2022
@adamchainz adamchainz changed the title Add django.db.models BaseIterable and subclasses Add django.db.models.query.BaseIterable and subclasses Nov 11, 2022
@adamchainz adamchainz merged commit 1b8c1b5 into typeddjango:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamchainz adamchainz adamchainz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module "django.db.models.query" has no attribute "ModelIterable"
2 participants
@CircuitCipher @adamchainz