-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.13.1 release #1241
Version 1.13.1 release #1241
Conversation
Wow looks like there are other issues with mypy 0.990 https://github.com/typeddjango/django-stubs/actions/runs/3421536321/jobs/5697823439#step:6:462 For the pytest tests you can add |
requirements.txt
Outdated
@@ -9,4 +9,4 @@ psycopg2-binary | |||
-e .[compatible-mypy] | |||
|
|||
# Overrides: | |||
mypy==0.982 | |||
mypy==0.990 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless mypy 0.991 solves the issues we're having, IMO we can make a release that's being tested with mypy==0.982
.
Having a release that solves some mypy 0.99x problems is better than delaying the release.
Of course having full support for latest mypy would be ideal, but right now I don't have time and interest to look into the CI failures.
I opened bug #1261 about the plugin internal error with mypy 0.99x. Let's defer mypy update for now and make a release anyway? |
@intgr would you like to do the release? :) |
Sure, I can give it a shot. What are the exact commands I should run; is there documentation somewhere? |
Plus |
Looks like I may have done it 😮
I will clean up the autogenerated release notes soon. |
Congrats 🎉 |
Let's hope that it will work!