Typehint common dunder methods #1238
Conversation
| @@ -4,7 +4,6 @@ from django.contrib.gis.gdal.base import GDALBase as GDALBase | |||
|
|
|||
| class Field(GDALBase): | |||
| ptr: Any = ... | |||
| __class__: Any = ... | |||
There was a problem hiding this comment.
These look like a mistake.
| @@ -65,7 +65,6 @@ class LazyObject: | |||
| __bytes__: Callable = ... | |||
| __bool__: Callable = ... | |||
| __dir__: Callable = ... | |||
| __class__: Any = ... | |||
| __ne__: Callable = ... | |||
| __hash__: Callable = ... | |||
There was a problem hiding this comment.
This can be turned into methods in the next PRs :)
|
You can now merge PRs yourself, go ahead :) |
|
Still seeing this message
Tried logging out and back in. |
|
@sobolevn In case you missed the previous comment: I still don't have permissions to merge. |
|
Sorry, this is the first time I use teams inside an org inside a repo :( But, it should be fine now! I've sent you a new invite. @adamchainz, it should be fine for you as well. Please, confirm :) |
|
Oh, it is fine for @intgr |
|
Yep it worked now, awesome! "Squash and merge" is the correct flow in this repository, right? Maybe we can disable the other merge options in project settings? So I can't click the wrong button by accident :) |
|
I also sometimes (rarely) use rebase and merge (when all commits make sense). I will change it, thank you! |
|
Nice work here, thanks. |
Was suggested in #1206 comments.