Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broaden some type annotations to accept lazy strings #1232

Closed
wants to merge 2 commits into from
Closed

Broaden some type annotations to accept lazy strings #1232

wants to merge 2 commits into from

Conversation

browniebroke
Copy link

I have made things!

Accept lazy string for a few places:

  • SuccessMessageMixin.success_message
  • ...

Related issues

Fix #1231

@sobolevn
Copy link
Member

sobolevn commented Nov 6, 2022

There's only 1 minute difference with another PR: #1233 😮

@browniebroke
Copy link
Author

browniebroke commented Nov 6, 2022 •
edited
Loading

There's only 1 minute difference with another PR: #1233 😮

Saw that 😂 I'm going to close this one as the other one looks more advanced already. Thanks for the fix @PIG208!

@browniebroke browniebroke deleted the fix/lazy-str-cls-attr branch November 6, 2022 18:56
@sobolevn
Copy link
Member

sobolevn commented Nov 6, 2022 •
edited
Loading

Thank you for your PR! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when setting gettext_lazy as class attribute
2 participants
@browniebroke @sobolevn