Adjust choices=
type variance for model fields
#1154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid getting stuck in an invariance pit. I don't think it makes sense to mix two tuple with named group elements in the same choices sequence(?).
This also changes the outermost container type to
Sequence
as e.g. bothtuple
andlist
are supported.Reason behind this is that I'm getting the following complaints from
mypy
:Docs: https://docs.djangoproject.com/en/4.1/ref/models/fields/#choices
I'm not sure if we should change
_FieldChoices
too? e.g.