move _default_manager to ModelBase #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Sep 13, 2022
django-stubs/db/models/base.pyi
Outdated
| class ModelBase(type): ... | ||
| class ModelBase(type): | ||
| @property | ||
| def _default_manager(cls: Type[_Self]) -> BaseManager[_Self]: ... |
There was a problem hiding this comment.
I think that mypy might not like cls to be bound to Type[Model] 🤔
There was a problem hiding this comment.
Yes, mypy's right, updated.
There was a problem hiding this comment.
I have no idea how to solve this, maybe a type: ignore should be introduced.
Indeed, there's no guarantee that ModelBase would receive cls that bounded to Model.
There was a problem hiding this comment.
I think we can fallback to the first solution + type: ignore
sobolevn
reviewed
Sep 14, 2022
django-stubs/db/models/base.pyi
Outdated
| @@ -18,16 +17,17 @@ class ModelState: | |||
|
|
|||
| class ModelBase(type): | |||
| @property | |||
| def _default_manager(cls: Type[_Model]) -> BaseManager[_Model]: ... | |||
| def objects(cls: Type[_Self]) -> BaseManager[_Self]: ... # type: ignore | |||
There was a problem hiding this comment.
Please, add a code for these ignores. --show-error-codes.
sobolevn
approved these changes
Sep 14, 2022
|
Please, make sure to fix |
|
@sobolevn I believe all checks have passed, what's blocking? |
This was referenced May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Move _default_manager from Model (as a
@classproperty) to ModelBase (as a@property)To match what exactly happens in django
https://github.com/django/django/blob/e14d08cd894e9d91cb5d9f44ba7532c1a223f458/django/db/models/base.py#L429
(and also makes pyright/pylance happy)
Related issues
see also #817.