Add BaseDatabaseWrapper.operators #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
force-pushed
the
db_wrapper_operations
branch
from
2165eaf to
1c1804d
Compare
sobolevn
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
BaseDatabaseWrapperitself doesn't include this attribute, but all subclasses are required to add it for the ORM to work. For example in the dummy backend and postgresql.I used
MutableMappingfor a broader type, because at least the Oracle backend uses a funky descriptor.Using
connection.operatorsis useful when implementing some ORM functions like custom lookups. The case I came across was in django-countries: https://github.com/smileychris/django-countries/blob/5bb48218ef77662b8287d979d652bc716082fe67/django_countries/fields.py#L470-L471Related issues
n/a