fix type hint for GenericSitemap(info_dict) #1111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR softens the invariant type hint
Dict
to the covariantMapping
ofdjango.contrib.sitemaps.GenericSitemap(info_dict)
.See Python type hints: typing.Mapping vs. typing.Dict - Stack Overflow
Docs: The sitemap framework # GenericSitemap
Motivation
Mypy error:
Test
In my local virtualenv I modified the file
site-packages/django-stubs/contrib/sitemaps/__init__.pyi
according to the change of this PR.Afterwars ran the mypy check again and the errors was gone.