Improve type hints for test client response.context #1100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Adding django-stubs to a project with a number of tests that make assertions against the test client's
response.context
like:This was resulting in errors like:
context
is gathered instore_rendered_templates
and attached inClient.request()
/AsyncClient.request()
, with possible flattening. It’s always aContextList
.This PR improves the type hints for
ContextList
to handle all the types it accepts, and updates_MonkeyPatchedWSGIResponse
/_MonkeyPatchedASGIResponse
. I used these hints with that project and many issues are fixed.Related issues
n/a