Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base_field type for SimpleArrayField #1097

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Fix base_field type for SimpleArrayField #1097

merged 2 commits into from
Aug 10, 2022

Conversation

adnathanail
Copy link
Contributor

@adnathanail adnathanail commented Aug 10, 2022 •
edited by sobolevn
Loading

Closes #1096

@adnathanail adnathanail mentioned this pull request Aug 10, 2022
Closed
sobolevn
sobolevn reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't forget to change __init__ as well.

@adnathanail
Copy link
Contributor Author

@sobolevn Thanks! Just realised that

I also added a failing/passing test case

@sobolevn sobolevn merged commit 3ac34f1 into typeddjango:master Aug 10, 2022
@adnathanail adnathanail deleted the fix-simplearrayfield-basefield-type branch August 10, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SimpleArrayField should accept forms.Field not Type[forms.Field]
2 participants
@adnathanail @sobolevn