Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type for @require_http_methods #1075

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Improve type for @require_http_methods #1075

merged 1 commit into from
Jul 26, 2022

Conversation

adamchainz
Copy link
Contributor

A list isn't strictly required - tuples and sets work too, and anything that supports __contains__, so use the Container ABC.

Related issues

no issue

@adamchainz adamchainz changed the title Improve types for @require_http_methods Improve type for @require_http_methods Jul 26, 2022
sobolevn
sobolevn approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit efc2d04 into typeddjango:master Jul 26, 2022
@adamchainz adamchainz deleted the improve_require_http_methods branch August 12, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamchainz @sobolevn