Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type stubs for EmptyManager #1039

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Fix type stubs for EmptyManager #1039

merged 1 commit into from
Jul 4, 2022

Conversation

ljodal
Copy link
Contributor

@ljodal ljodal commented Jul 2, 2022

This should be parametrized based on the passed model. This also removes the need for overriding the get_queryset method.

@ljodal
Fix type stubs for EmptyManager
973f1a9 
This should be parametrized based on the passed model. This also removes
the need for overriding the get_queryset method.
@ljodal ljodal mentioned this pull request Jul 2, 2022
Open
sobolevn
sobolevn approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should work with our django_stubs_ext as is. Correct me if I am wrong.

Thanks!

@sobolevn sobolevn merged commit ae30525 into typeddjango:master Jul 4, 2022
@ljodal ljodal deleted the fix-empty-manager-type-stubs branch July 4, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljodal @sobolevn