Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved return type of render_to_string(). #1036

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Improved return type of render_to_string(). #1036

merged 1 commit into from
Jun 30, 2022

Conversation

smithdc1
Copy link
Contributor

render_to_string() finds an _EngineTemplate and calls render() on it. Therefore it returns a SafeString.

sobolevn
sobolevn approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit f8cc99c into typeddjango:master Jun 30, 2022
@smithdc1 smithdc1 deleted the render_to_string branch June 30, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smithdc1 @sobolevn