Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set generic type of SimpleCookie #1018

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Set generic type of SimpleCookie #1018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions django-stubs/template/response.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class ContentNotRenderedError(Exception): ...
class SimpleTemplateResponse(HttpResponse):
content: Any = ...
closed: bool
cookies: SimpleCookie
cookies: SimpleCookie[str]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or bytes? Can you please double check that?

Copy link
Contributor Author

@w0rp w0rp Jun 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's meant to be str.

I also just noticed there are other instances of SimpleCookie in the codebase without type parameterts, such as in test/client.pyi. Maybe someone more familiar with cookies will come along and fix these types.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is str as per docs: https://docs.djangoproject.com/en/4.0/ref/request-response/#django.http.HttpRequest.COOKIES

status_code: int
rendering_attrs: Any = ...
template_name: _TemplateForResponseT = ...
Expand Down Expand Up @@ -48,7 +48,7 @@ class TemplateResponse(SimpleTemplateResponse):
closed: bool
context: RequestContext
context_data: Optional[Dict[str, Any]]
cookies: SimpleCookie
cookies: SimpleCookie[str]
csrf_cookie_set: bool
json: functools.partial
redirect_chain: List[Tuple[str, int]]
Expand Down