error: "bytes" has no attribute "tobytes"

[StefanBrand]

Bug report

What's wrong

mypy: error: "bytes" has no attribute "tobytes"

Contrary to shapely.LineString the wkb property of django.contrib.gis.geos.LineString is not of type bytes, but of type memoryview.

>>> type(geometry.boundary)
<class 'django.contrib.gis.geos.collections.MultiLineString'>
>>> type(geometry.boundary.wkb)
<class 'memoryview'>
>>> type(geometry.boundary.wkb.tobytes())
<class 'bytes'>

django-stubs/django-stubs/contrib/gis/gdal/geometries.pyi

Lines 62 to 63 in 2e504df

	@property
	def wkb(self) -> bytes: ...

How is that should be

Probably:

 @property 
 def wkb(self) -> memoryview: ... 

cc @ciscorn

Background information:

• Commit updating Django docs: django/django@7c884af
• Commit giving details about bytes vs memoryview: python/typing@f6c17dd

System information

• OS: Docker image python:3.9.16-bullseye
• python version: 3.9.16
• django version: 4.1.4
• mypy version: 0-991
• django-stubs version: 1.13.2

[intgr]

If you're up for it, for simple changes like this, you could also try submitting a PR.

[intgr]

ciscorn already added this to the existing PR. 👍

[StefanBrand]

If you're up for it, for simple changes like this, you could also try submitting a PR.

Cool, I'll keep it in mind in case I find something else. I've seen that this one is already covered in #1335