"OGRGeometry" has no attribute "__iter__" (not iterable)

[StefanBrand]

Bug report

What's wrong

Iterating on the return type of Layer.get_geoms throws:

"OGRGeometry" has no attribute "__iter__" (not iterable)

I think these lines are wrong:

django-stubs/django-stubs/contrib/gis/gdal/layer.pyi

Lines 43 to 46 in 2e504df

	@overload
	def get_geoms(self, geos: Literal[True] = ...) -> OGRGeometry: ...
	@overload
	def get_geoms(self, geos: Literal[False]) -> GEOSGeometry: ...

How is that should be

>>> type(layer.get_geoms())
<class 'list'>
>>> type(layer.get_geoms()[0])
<class 'django.contrib.gis.gdal.geometries.Polygon'>
>>> type(layer.get_geoms(geos=True)[0])
<class 'django.contrib.gis.geos.polygon.Polygon'>

I think the type definitions should be as follows (mind also the switched geos parameter):

    @overload
    def get_geoms(self, geos: Literal[False] = ...) -> list[OGRGeometry]: ...
    @overload
    def get_geoms(self, geos: Literal[True]) -> list[GEOSGeometry]: ...

What do you think, @ciscorn?

System information

• OS: Docker image python:3.9.16-bullseye
• python version: 3.9.16
• django version: 4.1.4
• mypy version: 0-991
• django-stubs version: 1.13.2

[intgr]

Related PR: #1299

[ciscorn]

@StefanBrand @intgr
Thank you for reporting. I've made a PR.