Remove fake "BaseExpression.deconstruct" method

This is actually provided on various Expression subclasses, but not on "BaseExpression" itself.
typeddjango · Sep 7, 2023 · 7ffaed3 · 7ffaed3
1 parent 972101c
commit 7ffaed3
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/django-stubs/db/models/expressions.pyi b/django-stubs/db/models/expressions.pyi
@@ -107,7 +107,6 @@ class BaseExpression:
     def reverse_ordering(self) -> BaseExpression: ...
     def flatten(self) -> Iterator[BaseExpression]: ...
     def as_sql(self, compiler: SQLCompiler, connection: BaseDatabaseWrapper) -> _AsSqlType: ...
-    def deconstruct(self) -> tuple[str, Sequence[Any], dict[str, Any]]: ...  # fake
 
 class Expression(BaseExpression, Combinable): ...
 

diff --git a/scripts/stubtest/allowlist_todo.txt b/scripts/stubtest/allowlist_todo.txt
@@ -1525,7 +1525,6 @@ django.db.models.expressions.BaseExpression.contains_aggregate
 django.db.models.expressions.BaseExpression.contains_column_references
 django.db.models.expressions.BaseExpression.contains_over_clause
 django.db.models.expressions.BaseExpression.convert_value
-django.db.models.expressions.BaseExpression.deconstruct
 django.db.models.expressions.BaseExpression.empty_result_set_value
 django.db.models.expressions.BaseExpression.get_refs
 django.db.models.expressions.BaseExpression.output_field