-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function redefine, other small changes for functions #379
base: 3.0
Are you sure you want to change the base?
Add function redefine, other small changes for functions #379
Conversation
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
75a37b2
to
7e91ed2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flag the hack
@@ -20,11 +23,12 @@ pub struct Function { | |||
span: Option<Span>, | |||
pub signature: Signature, | |||
pub block: FunctionBlock, | |||
pub unparsed: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flag a hack.
I'm supposed to use the span for this. But then I have to pass the unparsed query in the core functions.
I'm not sure whether I want to do that today or leave this in as a hack.
Usage and product changes
Adds function redefine syntax, and some small changes.
Implementation