Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Query::Type to ConceptRowStream #209

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

farost
Copy link
Member

@farost farost commented Sep 25, 2024

Release notes: usage and product changes

In 3.0, we no longer use parsers on our user-facing clients, and we no longer can differentiate the types of queries we are executing on the server. However, it can be sometimes useful (e.g. for extra logging/messaging) to have at least some information about the nature of the queries.
For these purposes, we add the executed query's type to ConceptRowStream.

Implementation

For now, it's just general Read/Write/Schema (like transaction types), which is enough for our existing tasks.

@typedb-bot
Copy link
Member

typedb-bot commented Sep 25, 2024

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@farost farost merged commit 47667a3 into typedb:3.0 Sep 26, 2024
1 check passed
farost added a commit to typedb/typedb that referenced this pull request Sep 26, 2024
…abase bdd steps (#7171)

## Release notes: product changes
We update the server to server the [updated
protocol](typedb/typedb-protocol#209) and return
the type of the executed query as a part of the query row stream answer.

We also fix the server's database manipulation code and implement
additional bdd steps to pass the `connection/database` bdd tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants