This repository has been archived by the owner on Nov 18, 2023. It is now read-only.
CI/CD improvements #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
January 28, 2019 12:42
…d test, used via bazel to test using local source and to test using the test pypi server
…than local source code
…and example end-to-end tests can be fun separately
…le dependency for little gain
…t. Setup needs to be added to the test itself.
Fixes broken PyPI deployment
lolski
approved these changes
Feb 4, 2019
| **Requirements:** | ||
|
|
||
| - Python 3.6.3 < version < 3.7 ([tensorflow doesn't yet support Python 3.7](https://github.com/tensorflow/tensorflow/issues/17022)) | ||
| - kglib installed from pip: `pip install --extra-index-url https://test.pypi.org/simple/ grakn-kglib` |
There was a problem hiding this comment.
needs to be changed to the proper url before release
| # Params for persisting to files | ||
| DIR = os.path.dirname(os.path.realpath(__file__)) | ||
| TIMESTAMP = time.strftime("%Y-%m-%d_%H-%M-%S") | ||
| # BASE_PATH = f'{DIR}/dataset/{NUM_PER_CLASS}_concepts/' |
There was a problem hiding this comment.
can we remove dead codes like these?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grakn-kglibfrom the PyPi test server-Updates READMEs, now there is one for the KGCN example, one for KGCN general usage, and one for the whole repo
Addresses #35 #36 #37 #31 #30