Skip to content
This repository has been archived by the owner on Nov 18, 2023. It is now read-only.

Improve clarity of diagnosis example #117

Merged
merged 3 commits into from
Dec 16, 2019

Conversation

jmsfltchr
Copy link
Contributor

What is the goal of this PR?

Reformat the diagnosis example to make it as clear as possible to users how they can build their own KGCN.

What are the changes implemented in this PR?

  • Move main parameters to be easily visible
  • Move out generic util methods for retrieving types and roles
  • Improved docstrings
  • Some outdated format docstrings updated to Google format

@jmsfltchr jmsfltchr added this to the 0.2.1 milestone Dec 16, 2019
@jmsfltchr jmsfltchr self-assigned this Dec 16, 2019
@jmsfltchr jmsfltchr requested a review from lolski December 16, 2019 15:30
@jmsfltchr jmsfltchr merged commit 6b028b5 into typedb:master Dec 16, 2019
@jmsfltchr jmsfltchr deleted the refactor-diagnosis branch December 16, 2019 16:04
@jmsfltchr jmsfltchr mentioned this pull request Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants