Skip to content
This repository has been archived by the owner on Nov 18, 2023. It is now read-only.

Diagnosis Example Fixes #115

Merged
merged 4 commits into from
Dec 16, 2019
Merged

Conversation

jmsfltchr
Copy link
Contributor

@jmsfltchr jmsfltchr commented Dec 16, 2019

What is the goal of this PR?

Fixes for the update to the diagnosis example.

What are the changes implemented in this PR?

  • Removes references to .collect_concepts() in favour of .get(<var>) for each element of the iterator.
  • Fixes diagnosis_test according to the new queries made to ingest predictions into Grakn

@jmsfltchr jmsfltchr added this to the 0.2.1 milestone Dec 16, 2019
@jmsfltchr jmsfltchr self-assigned this Dec 16, 2019
@jmsfltchr jmsfltchr changed the title Remove .collect_concepts() Diagnosis Example Fixes Dec 16, 2019
@jmsfltchr jmsfltchr requested a review from lolski December 16, 2019 11:36
@jmsfltchr jmsfltchr merged commit fd8acae into typedb:master Dec 16, 2019
@jmsfltchr jmsfltchr deleted the remove-collect-concepts branch December 16, 2019 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants