Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drug discovery example #6

Merged
merged 16 commits into from
Aug 24, 2023
Merged

Drug discovery example #6

merged 16 commits into from
Aug 24, 2023

Conversation

james-whiteside
Copy link
Contributor

@james-whiteside james-whiteside commented Aug 11, 2023

What is the goal of this PR?

This PR adds the drug discovery example to the repo.

What are the changes implemented in this PR?

  • Adds drug discovery example under drug-discovery directory.
  • Updates the top-level readme.

@typedb-bot
Copy link
Member

typedb-bot commented Aug 11, 2023

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

Copy link
Contributor

@SullivanDaly SullivanDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it a lot, anyway, ex2/3/4 are really close to each other (I understand that you need this to demonstrate the "chain" but maybe we can find a different way?).

Maybe the exercise 4 is also a bit too easy? (and maybe exercise 6 too?)

Except those remarks, still an great usecase!

@typedb-bot typedb-bot removed the request for review from shane-k-j August 23, 2023 14:07
@james-whiteside
Copy link
Contributor Author

Like it a lot, anyway, ex2/3/4 are really close to each other (I understand that you need this to demonstrate the "chain" but maybe we can find a different way?).

Maybe the exercise 4 is also a bit too easy? (and maybe exercise 6 too?)

Except those remarks, still an great usecase!

Following discussion, updated Exercise 04.

@james-whiteside james-whiteside changed the title Drug discovery example - DO NOT MERGE Drug discovery example Aug 24, 2023
@james-whiteside james-whiteside merged commit 1ff553d into typedb:master Aug 24, 2023
@james-whiteside james-whiteside deleted the drug-discovery branch August 24, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants