-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified CTI example #5
Conversation
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good in general, with a number of corrections for clarity/grammar.
With regards to structure of examples, try and phrase each example in natural language, and then state the query, for example:
# Let's write a query to find out which malware is used by the hacker Neo:
match
$h isa hacker, has name "Neo";
$m isa malware, has id $id;
(hacker: $h, malware: $m) isa uses;
If the query is particularly complex then you can add more context, but showing how to ask a given business question or perform a given business process is the goal. When it comes to the exercises, try and state the goal in natural language as well. It's then the user's task to translate that into TypeQL, with the keyword/type hints providing assistance.
I've provided a few suggestions of natural language for some examples. Feel free to use them or not, you know the domain better than I do.
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very close! But sorry one more round. In general it's coming together very nicely. In addition to the comments I've made, please change all the underscores to hyphens in all queries and comments (except in string literals obviously).
Co-authored-by: James Whiteside <[email protected]>
Co-authored-by: James Whiteside <[email protected]>
What is the goal of this PR?
This PR modifies the CTI example to demonstrate TypeDB's capabilities in a CTI environment.
What are the changes implemented in this PR?
Large number of improvements and optimisations to examples.