Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence send errors in network callbacks when receiver dropped #526

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

dmitrii-ubskii
Copy link
Member

Release notes: usage and product changes

Downgrade the "channel closed" SendError from ERROR to DEBUG when the receiving end of the stream is dropped before the stream is exhausted.

@typedb-bot
Copy link
Member

typedb-bot commented Nov 16, 2023

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@flyingsilverfin flyingsilverfin merged commit 99a8b93 into typedb:development Nov 16, 2023
@dmitrii-ubskii dmitrii-ubskii deleted the senderror branch November 21, 2023 18:02
dmitrii-ubskii added a commit to dmitrii-ubskii/typedb-driver that referenced this pull request Jan 8, 2024
…b#526)

## Release notes: usage and product changes

Downgrade the "channel closed" `SendError` from ERROR to DEBUG when the
receiving end of the stream is dropped before the stream is exhausted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants