-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX improvements: FFI logging, error message fix, Rust stream borrow checks #515
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5fd8e87
update rules_rust (via dependencies)
dmitrii-ubskii 7939fc0
docs
dmitrii-ubskii be8e13f
update rules rust (rebase)
dmitrii-ubskii c9f911c
Error message UX improvements
dmitrii-ubskii de3c0eb
query streams borrow transaction
dmitrii-ubskii 1fdfd45
Concept API streams borrow transaction
dmitrii-ubskii 3def9a1
unused import
dmitrii-ubskii c54a200
updated dependencies
dmitrii-ubskii 15c95ce
logic manager stream borrows transaction
dmitrii-ubskii edacb9f
env-logging over FFI
dmitrii-ubskii 616bec2
merged dependencies
dmitrii-ubskii a7aeaa6
docs
dmitrii-ubskii 45563ae
remove extra trace
dmitrii-ubskii 1794be2
fmt
dmitrii-ubskii cd0cf03
docs
dmitrii-ubskii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,9 +28,6 @@ | |
*/ | ||
public class TypeDBDriverException extends RuntimeException { | ||
|
||
@Nullable | ||
private final com.vaticle.typedb.driver.jni.Error nativeError; | ||
|
||
Comment on lines
-31
to
-33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We no longer store the native error and instead just take its message. |
||
@Nullable | ||
private final ErrorMessage errorMessage; | ||
|
||
|
@@ -40,7 +37,6 @@ public class TypeDBDriverException extends RuntimeException { | |
public TypeDBDriverException(ErrorMessage error, Object... parameters) { | ||
super(error.message(parameters)); | ||
assert !getMessage().contains("%s"); | ||
this.nativeError = null; | ||
this.errorMessage = error; | ||
} | ||
|
||
|
@@ -49,7 +45,6 @@ public TypeDBDriverException(ErrorMessage error, Object... parameters) { | |
*/ | ||
public TypeDBDriverException(String message, Throwable cause) { | ||
super(message, cause); | ||
this.nativeError = null; | ||
this.errorMessage = null; | ||
} | ||
|
||
|
@@ -59,8 +54,6 @@ public TypeDBDriverException(String message, Throwable cause) { | |
public TypeDBDriverException(RuntimeException error) { | ||
super(error.getMessage()); | ||
assert !getMessage().contains("%s"); | ||
if (error.getCause() instanceof com.vaticle.typedb.driver.jni.Error) this.nativeError = (com.vaticle.typedb.driver.jni.Error)error.getCause(); | ||
else this.nativeError = null; | ||
this.errorMessage = null; | ||
} | ||
|
||
|
@@ -70,7 +63,6 @@ public TypeDBDriverException(RuntimeException error) { | |
public TypeDBDriverException(com.vaticle.typedb.driver.jni.Error error) { | ||
super(error.getMessage()); | ||
assert !getMessage().contains("%s"); | ||
this.nativeError = error; | ||
this.errorMessage = null; | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function allows the FFI drivers to initialize the Rust logger. (Rust driver users can do this directly)